Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .env.example files #482

Merged
merged 2 commits into from
Sep 17, 2023
Merged

Add .env.example files #482

merged 2 commits into from
Sep 17, 2023

Conversation

andrew032011
Copy link
Collaborator

@andrew032011 andrew032011 commented Sep 12, 2023 •
edited
Loading

Summary

This should better streamline onboarding by giving some recommended settings for the .env files using .env.example files.

Onboarding doc updated to reflect these changes: https://www.notion.so/cornelldti/Dev-Onboarding-Fall-2023-95080438d831425c92f028ad4a31c185

Notion/Figma Link

Test Plan

Notes

Breaking Changes

@andrew032011 andrew032011 requested a review from a team as a code owner September 12, 2023 03:04
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 14.

alyssayzhang
alyssayzhang approved these changes Sep 17, 2023
View reviewed changes
Copy link
Contributor

@alyssayzhang alyssayzhang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm Andrew! 👍 This will definitely helpful for onboarding and setting up the environment. Thanks for working on this!

@andrew032011 andrew032011 merged commit f4cfebe into main Sep 17, 2023
12 checks passed
@andrew032011 andrew032011 deleted the u/axc/new_env_example_frontend branch September 17, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssayzhang alyssayzhang alyssayzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrew032011 @dti-github-bot @alyssayzhang