Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Documentation Field for Dev and TPM Portfolios #503

Merged
merged 6 commits into from
Sep 26, 2023
Merged

Add Documentation Field for Dev and TPM Portfolios #503

merged 6 commits into from
Sep 26, 2023

Conversation

andrew032011
Copy link
Collaborator

@andrew032011 andrew032011 commented Sep 26, 2023 •
edited
Loading

Summary

In response to the updated expectations for TPM and Dev portfolios, we're adding a new field for "Documentation" for both Devs and TPM views. This way, Devs and TPMs are reminded to include documentation, and they have a way of specifying the documentation they updated, whether or not it's in the PRs they submitted.

Update this in the DB schema and add a UI element.

Notion/Figma Link

https://www.notion.so/cornelldti/Add-Blurb-about-Linking-Documentation-for-TPM-Portfolio-bbcc3f76ec5844f981e90a7921083e17?pvs=4

Test Plan

Admin view:

Screenshot 2023-09-26 at 12 55 42 AM

Developer view:
Screenshot 2023-09-26 at 1 29 32 AM

Screenshot 2023-09-26 at 12 51 30 AM

TPM view:

Screenshot 2023-09-26 at 1 29 03 AM

@andrew032011 andrew032011 requested a review from a team as a code owner September 26, 2023 04:56
@dti-github-bot
Copy link
Member

dti-github-bot commented Sep 26, 2023 •
edited
Loading

[diff-counting] Significant lines: 41.

oscarwang20
oscarwang20 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@oscarwang20 oscarwang20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

        _
       /(|
      (  :
     __\  \  _____
   (____)  `|
  (____)|   |
   (____).__|
    (___)__.|_____
               LGTM!

michelleli01
michelleli01 reviewed Sep 26, 2023
View reviewed changes
Copy link

@michelleli01 michelleli01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Andrew, thank you so much for this PR it will be incredibly helpful to align with our new portfolio breakdown! I just wanted to leave some comments. Sorry again for not mentioning this to IDOL beforehand 😢

frontend/src/components/Forms/DevPortfolioForm/DevPortfolioForm.tsx Show resolved Hide resolved
frontend/src/components/Forms/DevPortfolioForm/DevPortfolioForm.tsx Outdated Show resolved Hide resolved
@andrew032011 andrew032011 merged commit c84e1cb into main Sep 26, 2023
10 checks passed
@andrew032011 andrew032011 deleted the u/axc/dev_portfolio_documentation_updates branch September 26, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscarwang20 oscarwang20 oscarwang20 approved these changes

@michelleli01 michelleli01 michelleli01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrew032011 @dti-github-bot @michelleli01 @oscarwang20