Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lecture slides to the lec 2 notes #20

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Conversation

Glitched
Copy link
Member

@Glitched Glitched commented Oct 2, 2019

No description provided.

Copy link
Contributor

@SamChou19815 SamChou19815 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SamChou19815
Copy link
Contributor

Looks like github actions have a bug now that prevents the merge: https://github.community/t5/GitHub-Actions/Required-status-pass-but-blocks-from-merging-Pull-Request/m-p/33568/highlight/false#M1568
If it's not resolved soon, I will temporarily disable the required status check for this to go through

@Glitched
Copy link
Member Author

Glitched commented Oct 2, 2019

Before you disable the checks, we could e-merge it. But let's try waiting a bit and seeing if they fix it up

@SamChou19815
Copy link
Contributor

Looks like github fixed the blocking bug, but now the required badge besides status disappears 😞

@SamChou19815 SamChou19815 merged commit 789cd80 into master Oct 2, 2019
@SamChou19815 SamChou19815 deleted the lec2_slides branch October 2, 2019 19:09
@ptwu ptwu mentioned this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants