-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MLIR] New Frontend with HeteroCL AST #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enable opt-level=1 in LLVM backend
This was referenced Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR revamps the Python front to resolve the issues with generating MLIR IR during tracing. Generating IR on the fly can insert MLIR operations at the wrong scope for imperative programs. This is caused by the Python expression evaluation order and MLIR being SSA.
We propose a solution that builds an "intermediate" layer of abstraction in Python and takes a second pass to build IR in MLIR. This layer of abstraction is HeteroCL AST. There are more benefits of introducing HeteroCL AST:
Major Changes
HCL AST Model
Operation: FuncOp, ComputeOp, IfOp, ElifOp, ElseOp, ForOp, StoreOp, ReuseAtOp …
Expr: LoadOp, UnaryOp, BinaryOp, TernaryOp, …
New Frontend Workflow
API Changes
schedule.ast
schedule.device_module
, changing toschedule.module
hcl.lower
instead of duringhcl.create_schedule
.Tests
The new front-end implementation passes the same tests as the
hcl-mlir
branch.Additionally, it passes tutorial tests. Tutorial tests are also enabled by this PR.