Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change _dtype_value_context init args to *_value. #47

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Change _dtype_value_context init args to *_value. #47

merged 1 commit into from
Jan 17, 2023

Conversation

Balandat
Copy link
Collaborator

Addresses #46. Also gets rid of an old DeprecationWarning

@gpleiss gpleiss merged commit 2893995 into cornellius-gp:main Jan 17, 2023
@gpleiss gpleiss mentioned this pull request Jan 17, 2023
Closed
@saitcakmak
Copy link
Collaborator

saitcakmak commented Jan 24, 2023 •
edited
Loading

This is missing a dtype arg in self.__class__.value() calls. Working on a fix.

Surfaced in https://github.com/pytorch/botorch/actions/runs/3990958264/jobs/6845226501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpleiss gpleiss gpleiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Balandat @saitcakmak @gpleiss