sound.ts added #13
Merged
sound.ts added #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for skyscraper-game ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/Components/Sound.ts
Outdated
Comment on lines
30
to
36
| this.audio.addEventListener('ended', () => { | ||
| if (count > 1) { | ||
| count--; | ||
| this.audio.currentTime = 0; | ||
| this.audio.play(); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Please move this function into private method decreaseCounter
src/Components/Sound.ts
Outdated
Comment on lines
44
to
55
|
|
||
| // usage: | ||
| const tapBlockSound = new Sound('public/sound/tapBlock.wav'); | ||
| const gameOverSound = new Sound('public/sound/gameOverSound.wav'); | ||
|
|
||
| // To play the sounds: | ||
| tapBlockSound.play(); | ||
| gameOverSound.play(); | ||
|
|
||
|
|
||
| tapBlockSound.setVolume(0.5); | ||
| gameOverSound.repeat(2); |
src/Components/Sound.ts
Outdated
Comment on lines
2
to
7
| interface Sound { | ||
| play(): void; // play sound | ||
| stop(): void; // stop sound | ||
| repeat(count: number): void; // repeat sound `count` times or infinity | ||
| setVolume(value: number): void; // set volume of sound | ||
| } |
There was a problem hiding this comment.
Please remove comments from interface
Rename interface to ISound
src/Components/Sound.ts
Outdated
| setVolume(value: number): void; // set volume of sound | ||
| } | ||
|
|
||
| class Sound implements Sound { |
There was a problem hiding this comment.
Change to
export default class Sound implements ISound {| repeat(count: number) { | ||
| if (count === Infinity) { | ||
| this.audio.loop = true; | ||
| } else if (count > 0) { |
|
on it @corners2wall |
|
@Vidhanvyrs Good job!!! |
Closed
Thankyou 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.