Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Contact journal comment info screen (EXPOSUREAPP-5109) #2357

Merged
merged 3 commits into from
Feb 17, 2021
Merged

Contact journal comment info screen (EXPOSUREAPP-5109) #2357

merged 3 commits into from
Feb 17, 2021

Conversation

AlexanderAlferov
Copy link
Contributor

Small fragment with information regarding comments in contact diary.

How to test:

  1. open testers menu
  2. last button "Contact Diary Comment Info"

Vuzix View_20210215_192627_013

@AlexanderAlferov AlexanderAlferov added maintainers Tag pull requests created by maintainers text change PRs with text changes. labels Feb 15, 2021
@AlexanderAlferov AlexanderAlferov added this to the 1.13.0 milestone Feb 15, 2021
@AlexanderAlferov AlexanderAlferov marked this pull request as draft February 15, 2021 16:32
@harambasicluka harambasicluka modified the milestones: 1.13.0, 1.14.0 Feb 15, 2021
@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AlexanderAlferov AlexanderAlferov marked this pull request as ready for review February 15, 2021 17:11
@ralfgehrer ralfgehrer self-assigned this Feb 17, 2021
ralfgehrer
ralfgehrer reviewed Feb 17, 2021
View reviewed changes
Copy link
Contributor

@ralfgehrer ralfgehrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on a Pixel (Android 10).

janetback
janetback approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@janetback janetback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA reviewed

@d4rken d4rken self-assigned this Feb 17, 2021
@d4rken d4rken merged commit 57ce870 into feature/4741-contact-journal-extension-main Feb 17, 2021
@d4rken d4rken deleted the feature/5109-contact-journal-comment-info-screen branch February 17, 2021 10:05
@dsarkar dsarkar mentioned this pull request Feb 22, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janetback janetback janetback approved these changes

@d4rken d4rken d4rken approved these changes

@ralfgehrer ralfgehrer ralfgehrer approved these changes

@SamuraiKek SamuraiKek Awaiting requested review from SamuraiKek

@harambasicluka harambasicluka Awaiting requested review from harambasicluka

Assignees

@ralfgehrer ralfgehrer

@d4rken d4rken

Labels
maintainers Tag pull requests created by maintainers text change PRs with text changes.
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@AlexanderAlferov @ralfgehrer @d4rken @janetback @harambasicluka