This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 495
Collect test result data (EXPOSUREAPP-4820) #2372
Merged
mtwalli
merged 53 commits into
release/1.14.x
from
feature/4820-collect-test-result-data
Feb 23, 2021
Merged
Collect test result data (EXPOSUREAPP-4820) #2372
mtwalli
merged 53 commits into
release/1.14.x
from
feature/4820-collect-test-result-data
Feb 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4rken
reviewed
Feb 17, 2021
...n-App/src/main/java/de/rki/coronawarnapp/datadonation/analytics/storage/AnalyticsSettings.kt
Outdated
Show resolved
Hide resolved
kolyaopahle
previously approved these changes
Feb 23, 2021
chiljamgossow
suggested changes
Feb 23, 2021
...n-App/src/main/java/de/rki/coronawarnapp/datadonation/analytics/storage/AnalyticsSettings.kt
Outdated
Show resolved
Hide resolved
...n/java/de/rki/coronawarnapp/datadonation/analytics/modules/registeredtest/TestResultDonor.kt
Outdated
Show resolved
Hide resolved
...n/java/de/rki/coronawarnapp/datadonation/analytics/modules/registeredtest/TestResultDonor.kt
Show resolved
Hide resolved
...rc/main/java/de/rki/coronawarnapp/ui/submission/qrcode/scan/SubmissionQRCodeScanViewModel.kt
Outdated
Show resolved
Hide resolved
kolyaopahle
approved these changes
Feb 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I tested the data appeared repeatedly in the analytics
The data is not repeated, As I mentioned in the chat. It can be created multiple times as long as the submission is not done. |
Kudos, SonarCloud Quality Gate passed! |
chiljamgossow
approved these changes
Feb 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestResultDonor
The idea is the following:
if the test result turns POSITIVE or NEGATIVE, it is included in the next submission. Afterwards, the collected metric data is removed.
More than
hoursSinceTestRegistration
hours have passed since the test was registered, it is included in the next submission and removed afterwards. That means if the test result turns POS or NEG afterwards, this will not submittedTesting
Test result metadata
won't be created anymore.TODO