Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Collect test result data (EXPOSUREAPP-4820) #2372

Merged
merged 53 commits into from
Feb 23, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Feb 16, 2021

  • Implements TestResultDonor
  • I don't persist initial data as it will be overwritten later before submission.

The idea is the following:

  • if the test result turns POSITIVE or NEGATIVE, it is included in the next submission. Afterwards, the collected metric data is removed.

  • More than hoursSinceTestRegistration hours have passed since the test was registered, it is included in the next submission and removed afterwards. That means if the test result turns POS or NEG afterwards, this will not submitted

Testing

  • From test menu you can create and submit data to the server.
  • Once data submitted if you hit create again Test result metadata won't be created anymore.

TODO

  • Finalise logic
  • Add unit tests

@mtwalli mtwalli added the maintainers Tag pull requests created by maintainers label Feb 16, 2021
@mtwalli mtwalli added this to the 1.14.0 milestone Feb 16, 2021
kolyaopahle
kolyaopahle previously approved these changes Feb 23, 2021
Copy link
Contributor

@chiljamgossow chiljamgossow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tested the data appeared repeatedly in the analytics

@mtwalli
Copy link
Contributor Author

mtwalli commented Feb 23, 2021

When I tested the data appeared repeatedly in the analytics

The data is not repeated, As I mentioned in the chat. It can be created multiple times as long as the submission is not done.
Please check also the logs , you might see that sending analytics to the sever is failing. In case it failed data is collected again on demand

@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

6.3% 6.3% Coverage
0.0% 0.0% Duplication

@mtwalli mtwalli merged commit 8b86e85 into release/1.14.x Feb 23, 2021
@mtwalli mtwalli deleted the feature/4820-collect-test-result-data branch February 23, 2021 21:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants