Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Remove trailing commas from attributes list (DEV) #2457

Merged
merged 5 commits into from
Feb 24, 2021
Merged

Remove trailing commas from attributes list (DEV) #2457

merged 5 commits into from
Feb 24, 2021

Conversation

SamuraiKek
Copy link
Contributor

No description provided.

@SamuraiKek SamuraiKek added the maintainers Tag pull requests created by maintainers label Feb 24, 2021
@SamuraiKek SamuraiKek added this to the 1.14.0 milestone Feb 24, 2021
@SamuraiKek SamuraiKek requested a review from a team February 24, 2021 13:11
@LukasLechnerDev
Copy link
Contributor

In Kotlin 1.4, trailing commas are a feature, here it is a bug 😂

LukasLechnerDev
LukasLechnerDev approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@LukasLechnerDev LukasLechnerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no more trailing commas in contact diary overview

@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ralfgehrer ralfgehrer merged commit 4141f6c into release/1.14.x Feb 24, 2021
@ralfgehrer ralfgehrer deleted the fix/4741-contact-diary-trailing-comma branch February 24, 2021 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@axelherbstreith axelherbstreith axelherbstreith approved these changes

@mtwalli mtwalli mtwalli approved these changes

@LukasLechnerDev LukasLechnerDev LukasLechnerDev approved these changes

Assignees

@mtwalli mtwalli

@axelherbstreith axelherbstreith

Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@SamuraiKek @LukasLechnerDev @mtwalli @axelherbstreith @ralfgehrer