This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Fix timeformat. API expects exposureWindow timestamp to be in seconds. (EXPOSUREAPP-5529) #2518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4rken
added
bug
ralfgehrer
reviewed
Mar 4, 2021
| @@ -76,7 +76,7 @@ internal fun List<AnalyticsExposureWindowEntityWrapper>.asPpaData() = map { | |||
| } | |||
|
|
|||
| val exposureWindow = PpaData.PPAExposureWindow.newBuilder() | |||
| .setDate(it.exposureWindowEntity.dateMillis) | |||
| .setDate(it.exposureWindowEntity.dateMillis / 1000) | |||
There was a problem hiding this comment.
very minor: didn't we have an extension function for this?
ralfgehrer
approved these changes
Mar 4, 2021
chiljamgossow
approved these changes
Mar 4, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Milliseconds to seconds + a unit test.