Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

text change red tile (increased risk) remove free test hint (EXPOSUREAPP-13456) #5315

Merged
merged 2 commits into from
Jul 1, 2022

Conversation

schauersbergern
Copy link
Contributor

@schauersbergern schauersbergern added bug Something isn't working maintainers Tag pull requests created by maintainers text change PRs with text changes. labels Jul 1, 2022
@schauersbergern schauersbergern added this to the 2.24.x milestone Jul 1, 2022
@schauersbergern schauersbergern requested a review from a team July 1, 2022 12:45
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

Unit Test Results - Device Release

   555 files  ±0     555 suites  ±0   6m 5s ⏱️ +15s
2 742 tests ±0  2 742 ✔️ ±0  0 💤 ±0  0 ±0 
2 791 runs  ±0  2 791 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 5ac02de. ± Comparison against base commit 6fef6f8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

Firebase Test Results

    2 files  ±0      2 suites  ±0   4m 35s ⏱️ - 1m 5s
129 tests ±0  129 ✔️ ±0  0 💤 ±0  0 ±0 
258 runs  ±0  258 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 5ac02de. ± Comparison against base commit 6fef6f8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

Unit Test Results - Device For Tester Release

   558 files  ±0     558 suites  ±0   5m 58s ⏱️ +19s
2 748 tests ±0  2 748 ✔️ ±0  0 💤 ±0  0 ±0 
2 797 runs  ±0  2 797 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 5ac02de. ± Comparison against base commit 6fef6f8.

♻️ This comment has been updated with latest results.

@@ -273,7 +273,7 @@
<!-- XTXT: find details about exposures in the contact journal - increased risk -->
<string name="risk_details_find_details_in_journal_increased_risk">Weitere Informationen zu Ihren Risiko-Begegnungen finden Sie in Ihrem Kontakt-Tagebuch.\n\nSie haben ein erhöhtes Risiko, sich angesteckt zu haben. Falls Sie infiziert sind, können Sie Ihrerseits andere Personen anstecken, auch wenn Sie geimpft oder genesen sind, und auch, wenn Sie keine Symptome haben.</string>
<!-- XMSG: risk details - link to faq, something like a bullet point -->
<string name="risk_details_increased_risk_faq_link_text">"Lassen Sie sich testen, auch wenn Sie keine Symptome haben. Bei einer Warnung über ein erhöhtes Risiko („Rote Kachel“) haben Sie Anspruch auf einen kostenlosen Test. Dies muss nicht notwendigerweise ein PCR-Test sein."</string>
<string name="risk_details_increased_risk_faq_link_text">"Lassen Sie sich testen, z.B. mit einem Antigen-Schnelltest, oder testen Sie sich selbst, am besten mehrfach im Abstand von zwei Tagen. Sollte ein Test positiv ausfallen, lassen Sie diesen durch einen PCR-Test absichern."</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to DIN 5008 z.B. should be written with a space e.g. z.&nbsp;B.

Copy link
Contributor Author

@schauersbergern schauersbergern Jul 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we use the plain z.B. without &nbsp; throughout the whole text files, so I wouldn't change that now in this pull request

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it would not be good to introduce inconsistencies in this PR even if the orthography is incorrect according to DIN rules.

@sonarcloud
Copy link

sonarcloud bot commented Jul 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@schauersbergern schauersbergern merged commit 9aa184d into release/2.24.x Jul 1, 2022
@schauersbergern schauersbergern deleted the fix/13456-text_change branch July 1, 2022 14:22
@MikeMcC399
Copy link
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working maintainers Tag pull requests created by maintainers text change PRs with text changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants