Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

introducing: days-to-publish #1711

Merged
merged 4 commits into from
Feb 4, 2022
Merged

introducing: days-to-publish #1711

merged 4 commits into from
Feb 4, 2022

Conversation

hilmarf
Copy link
Member

@hilmarf hilmarf commented Feb 3, 2022

No description provided.

@hilmarf hilmarf requested a review from ioangut February 3, 2022 10:29
@@ -20,6 +20,8 @@ services:
output-file-name-v2: index-v2
# The number of days to retain diagnosis keys and trace time warnings for both database persistency layer and files stored on the object store.
retention-days: 14
# The number of days for diagnosis keys (based upon submission timestamp) to publish on CDN.
days-to-publish: ${DAYS_TO_PUBLISH:10}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This effectively means CWA does not take the last 14 days into account but only the last 10, correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes - but still under discussion and not clear if it will come or not... but I'd like to be prepared when things get urgent :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thanks @hilmarf!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change now live? If yes, several texts in the app need updating, as well as the website.

@hilmarf hilmarf marked this pull request as ready for review February 4, 2022 12:00
@hilmarf hilmarf requested review from a team, roesslerj and CManole February 4, 2022 12:00
@hilmarf hilmarf enabled auto-merge (squash) February 4, 2022 12:00
@hilmarf hilmarf added this to the 2.18 milestone Feb 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@hilmarf hilmarf merged commit e2c5e13 into main Feb 4, 2022
@hilmarf hilmarf deleted the ten_day_packages_only branch February 4, 2022 13:05
@Ein-Tim
Copy link
Contributor

Ein-Tim commented Feb 7, 2022

@hilmarf Please, could you let us know if this change is live already?

@hilmarf
Copy link
Member Author

hilmarf commented Feb 7, 2022

@hilmarf Please, could you let us know if this change is live already?

Backend was updated today around 19h
Yes, it's live already.

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Feb 7, 2022

@hilmarf

Ok, thanks! Just to be sure, on https://svc90.main.px.t-online.de/version/v1/diagnosis-keys/country/EUR/date I see the dates 2022-01-27 - 2022-02-06

So the last 11 days, without today. So are the last 11 days considered, or?

FYI @vaubaehn

@hilmarf
Copy link
Member Author

hilmarf commented Feb 7, 2022

good catch!

yeah, the HF was deployed with wrong environment setting :-(

now it has been corrected and https://svc90.main.px.t-online.de/version/v1/diagnosis-keys/country/EUR/date shows only last 10 days

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Feb 7, 2022

@hilmarf

Okay, nice, so only the last 10 days are taken into account now. Thank you!

@vaubaehn
Copy link

vaubaehn commented Feb 7, 2022

good catch!

yeah, the HF was deployed with wrong environment setting :-(

now it has been corrected and https://svc90.main.px.t-online.de/version/v1/diagnosis-keys/country/EUR/date shows only last 10 days

confirmed 😉 Thanks for the quick fix, as it supports us Android users with ~500MB more free storage...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants