Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Covid Category and adds Patient Category in Daily Rounds and Consultation #1007

Merged
merged 8 commits into from
Sep 14, 2022

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Sep 8, 2022

Closes #875
Related FE issue: ohcnetwork/care_fe#2210

Step by step changes:

  • 1. Deprecates existing patient_category of DailyRound and category of PatientConsultation to deprecated_covid_category
  • 2. Migrations for the renamed deprecated fields.
  • 3. Adds mandatory fields patient_category in DailyRound and category in PatientConsultation with new CATEGORY_CHOICES.
  • 4. Migrations for the newly created fields.

@coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

renames existing `CATEGORY_CHOICES` to `COVID_CATEGORY_CHOICES`
rename `category` and `patient_category` in DailyRounds and Consultation to `deprecated_covid_category`
- Adds `patient_category` in DailyRounds
- Adds `category` in Consulation
@codecov-commenter
Copy link

Codecov Report

Merging #1007 (d5524df) into master (6bd66bf) will decrease coverage by 1.30%.
The diff coverage is 58.96%.

@@            Coverage Diff             @@
##           master    #1007      +/-   ##
==========================================
- Coverage   54.02%   52.71%   -1.31%     
==========================================
  Files         182      183       +1     
  Lines        8990     8944      -46     
==========================================
- Hits         4857     4715     -142     
- Misses       4133     4229      +96     
Impacted Files Coverage Δ
...re/facility/management/commands/scrape_icd_data.py 0.00% <0.00%> (ø)
care/facility/models/file_upload.py 68.88% <0.00%> (ø)
care/facility/models/json_schema/asset.py 100.00% <ø> (ø)
care/facility/static_data/icd11.py 0.00% <0.00%> (ø)
care/users/api/viewsets/users.py 42.94% <0.00%> (-12.90%) ⬇️
care/utils/assetintegration/onvif.py 38.23% <ø> (+1.09%) ⬆️
care/facility/api/viewsets/file_upload.py 48.57% <15.38%> (-2.95%) ⬇️
...e/facility/api/serializers/patient_consultation.py 34.54% <23.80%> (-2.45%) ⬇️
care/facility/api/viewsets/patient.py 48.08% <25.00%> (-0.16%) ⬇️
care/facility/api/viewsets/icd.py 36.84% <36.84%> (ø)
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rithviknishad
Copy link
Member Author

Required by ohcnetwork/care_fe#3565

@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vigneshhari vigneshhari merged commit 45798c1 into ohcnetwork:master Sep 14, 2022
vigneshhari pushed a commit that referenced this pull request Sep 15, 2022
…d Consultation (#1007)

* step 1. deprecate covid category
renames existing `CATEGORY_CHOICES` to `COVID_CATEGORY_CHOICES`

* step 1. deprecate covid category
rename `category` and `patient_category` in DailyRounds and Consultation to `deprecated_covid_category`

* step 2: make migrations for deprecating patient cateogry to covid category

* step 3: adds new `CATEGORY_CHOICES`

* step 3: use new `CATEGORY_CHOICES` wherever required

* step 4: make migrations for new fields
- Adds `patient_category` in DailyRounds
- Adds `category` in Consulation

* empty commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patient Category choices to be updated
4 participants