-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Covid Category and adds Patient Category in Daily Rounds and Consultation #1007
Merged
vigneshhari
merged 8 commits into
ohcnetwork:master
from
rithviknishad:patient-category-v2
Sep 14, 2022
Merged
Deprecate Covid Category and adds Patient Category in Daily Rounds and Consultation #1007
vigneshhari
merged 8 commits into
ohcnetwork:master
from
rithviknishad:patient-category-v2
Sep 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renames existing `CATEGORY_CHOICES` to `COVID_CATEGORY_CHOICES`
rename `category` and `patient_category` in DailyRounds and Consultation to `deprecated_covid_category`
- Adds `patient_category` in DailyRounds - Adds `category` in Consulation
Codecov Report
@@ Coverage Diff @@
## master #1007 +/- ##
==========================================
- Coverage 54.02% 52.71% -1.31%
==========================================
Files 182 183 +1
Lines 8990 8944 -46
==========================================
- Hits 4857 4715 -142
- Misses 4133 4229 +96
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
6 tasks
Required by ohcnetwork/care_fe#3565 |
sainak
approved these changes
Sep 10, 2022
vigneshhari
approved these changes
Sep 14, 2022
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
vigneshhari
approved these changes
Sep 14, 2022
vigneshhari
pushed a commit
that referenced
this pull request
Sep 15, 2022
…d Consultation (#1007) * step 1. deprecate covid category renames existing `CATEGORY_CHOICES` to `COVID_CATEGORY_CHOICES` * step 1. deprecate covid category rename `category` and `patient_category` in DailyRounds and Consultation to `deprecated_covid_category` * step 2: make migrations for deprecating patient cateogry to covid category * step 3: adds new `CATEGORY_CHOICES` * step 3: use new `CATEGORY_CHOICES` wherever required * step 4: make migrations for new fields - Adds `patient_category` in DailyRounds - Adds `category` in Consulation * empty commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #875
Related FE issue: ohcnetwork/care_fe#2210
Step by step changes:
patient_category
of DailyRound andcategory
of PatientConsultation todeprecated_covid_category
patient_category
in DailyRound andcategory
in PatientConsultation with newCATEGORY_CHOICES
.@coronasafe/code-reviewers
Merge Checklist