Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make middleware_hostname optional #1136

Merged
merged 1 commit into from
Dec 24, 2022
Merged

Make middleware_hostname optional #1136

merged 1 commit into from
Dec 24, 2022

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented Dec 24, 2022

Proposed Changes

  • made middleware_hostname optional in assets meta
  • made necessary migrations

Associated Issue

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@khavinshankar khavinshankar requested a review from a team as a code owner December 24, 2022 10:10
@sonarcloud
Copy link

sonarcloud bot commented Dec 24, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Base: 55.66% // Head: 55.66% // No change to project coverage 👍

Coverage data is based on head (2b876b9) compared to base (e8d97be).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1136   +/-   ##
=======================================
  Coverage   55.66%   55.66%           
=======================================
  Files         177      177           
  Lines        8769     8769           
  Branches     1505     1505           
=======================================
  Hits         4881     4881           
  Misses       3836     3836           
  Partials       52       52           
Impacted Files Coverage Δ
care/facility/models/json_schema/asset.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vigneshhari vigneshhari merged commit 8cf80f3 into master Dec 24, 2022
@sainak sainak deleted the fix#1135 branch June 6, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't save configuration for new HL7 Monitor assets Unable to configure the asset
3 participants