Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Patient Category Filter #1245

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Fixes Patient Category Filter #1245

merged 1 commit into from
Apr 12, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Apr 12, 2023

Proposed Changes

If a patient has a last daily round, it's filtered by the last daily round category.
Else filter by the last consultation's category as usual.

Co-authored by @Ashesh3

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.02 ⚠️

Comparison is base (40f722c) 56.22% compared to head (e3c12e2) 56.21%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1245      +/-   ##
==========================================
- Coverage   56.22%   56.21%   -0.02%     
==========================================
  Files         193      193              
  Lines        9517     9521       +4     
  Branches     1607     1608       +1     
==========================================
+ Hits         5351     5352       +1     
- Misses       4111     4114       +3     
  Partials       55       55              
Impacted Files Coverage Δ
care/facility/api/viewsets/patient.py 45.65% <25.00%> (-0.26%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gigincg gigincg merged commit d541d74 into master Apr 12, 2023
@sainak sainak deleted the fix-patient-filter-cat branch June 6, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patient Category Filters not filtering based on last daily round
3 participants