Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for Shifting status: Canceled #1272

Merged
merged 4 commits into from
Apr 27, 2023
Merged

Conversation

sainak
Copy link
Member

@sainak sainak commented Apr 25, 2023

Proposed Changes

  • if a shifting request is cancelled it must NOT be editable
  • only users linked to origin facility shall have the permission to cancel a shifting request

Associated Issue

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@sainak sainak requested a review from a team as a code owner April 25, 2023 09:51
@sainak sainak marked this pull request as draft April 25, 2023 12:07
@sainak sainak marked this pull request as ready for review April 27, 2023 09:32
@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (4ff0591) 56.32% compared to head (511d2ef) 56.29%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1272      +/-   ##
==========================================
- Coverage   56.32%   56.29%   -0.04%     
==========================================
  Files         195      195              
  Lines        9576     9582       +6     
  Branches     1606     1609       +3     
==========================================
  Hits         5394     5394              
- Misses       4127     4133       +6     
  Partials       55       55              
Impacted Files Coverage Δ
care/facility/api/serializers/shifting.py 49.65% <0.00%> (-2.18%) ⬇️
care/facility/models/shifting.py 79.03% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gigincg gigincg merged commit df7a4ed into master Apr 27, 2023
@sainak sainak deleted the fix/shifting-permissions branch June 2, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shifting status: Canceled
3 participants