Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: centralise linting across the project #1288

Merged
merged 7 commits into from
Jun 6, 2023

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented May 6, 2023

Bug Fix

Proposed Changes

  • Updates the linting of the codebase

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@coronasafe/code-reviewers

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2023

Codecov Report

Patch coverage: 47.38% and project coverage change: -0.02 ⚠️

Comparison is base (7979928) 56.72% compared to head (2f7cc7a) 56.70%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1288      +/-   ##
==========================================
- Coverage   56.72%   56.70%   -0.02%     
==========================================
  Files         199      195       -4     
  Lines        9863     9810      -53     
  Branches     1645     1645              
==========================================
- Hits         5595     5563      -32     
+ Misses       4213     4192      -21     
  Partials       55       55              
Impacted Files Coverage Δ
care/__init__.py 100.00% <ø> (ø)
care/audit_log/receivers.py 26.26% <0.00%> (ø)
care/facility/api/serializers/asset.py 60.91% <ø> (ø)
care/facility/api/serializers/daily_round.py 33.55% <ø> (ø)
care/facility/api/serializers/patient_otp.py 50.00% <0.00%> (-1.52%) ⬇️
care/facility/api/viewsets/__init__.py 100.00% <ø> (ø)
care/facility/api/viewsets/daily_round.py 42.10% <ø> (ø)
care/facility/api/viewsets/facility_capacity.py 48.78% <0.00%> (ø)
...anagement/commands/add_daily_round_consultation.py 0.00% <0.00%> (ø)
...facility/management/commands/port_patient_wards.py 0.00% <0.00%> (ø)
... and 32 more

... and 60 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aeswibon aeswibon marked this pull request as ready for review May 7, 2023 08:18
@aeswibon aeswibon requested a review from a team as a code owner May 7, 2023 08:18
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cp-coder
Unable to run this branch. Can you make sure you've resolved the merge conflicts correctly?

image

Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rithviknishad
Copy link
Member

@nihal467 would be doing a full test on this post this weeks release

@sonarcloud
Copy link

sonarcloud bot commented May 25, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 27 Security Hotspots
Code Smell A 58 Code Smells

No Coverage information No Coverage information
15.7% 15.7% Duplication

@nihal467
Copy link
Member

nihal467 commented May 30, 2023

LGTM, tested through Rithvik's tunnel using existing staging replica

CC: @rithviknishad @sainak @vigneshhari

@vigneshhari vigneshhari merged commit 03e4a76 into ohcnetwork:master Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Centralise Linting across the project
6 participants