-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: centralise linting across the project #1288
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #1288 +/- ##
==========================================
- Coverage 56.72% 56.70% -0.02%
==========================================
Files 199 195 -4
Lines 9863 9810 -53
Branches 1645 1645
==========================================
- Hits 5595 5563 -32
+ Misses 4213 4192 -21
Partials 55 55
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cp-coder
Unable to run this branch. Can you make sure you've resolved the merge conflicts correctly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@nihal467 would be doing a full test on this post this weeks release |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
LGTM, tested through Rithvik's tunnel using existing staging replica |
Bug Fix
Proposed Changes
Associated Issue
Merge Checklist
/docs
@coronasafe/code-reviewers