Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a way to handle filtering admitted but no bed assigned #1318

Merged
merged 23 commits into from
Sep 11, 2023
Merged

Added a way to handle filtering admitted but no bed assigned #1318

merged 23 commits into from
Sep 11, 2023

Conversation

yaswanthsaivendra
Copy link
Contributor

@yaswanthsaivendra yaswanthsaivendra commented May 27, 2023 •
edited
Loading

Proposed Changes

  • updated the PatientFilterSet to handle the None option
  • made the necessary change in frontend and created an PR for the same.

Associated Issue

Architecture changes

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

yaswanthsaivendra and others added 9 commits May 23, 2023 16:21
@yaswanthsaivendra
used prefetch_related method to optimize the query performed to fetch…
8946d5f 
… a many to many relationship
@yaswanthsaivendra
Revert "add direnv support (ohcnetwork#1304)"
7d410fd 
This reverts commit f613661.
@yaswanthsaivendra
Revert "Revert "add direnv support (ohcnetwork#1304)""
7179fdf 
This reverts commit 7d410fd.
@yaswanthsaivendra
Revert "used prefetch_related method to optimize the query performed …
9cb5f7c 
…to fetch a many to many relationship"

This reverts commit 8946d5f.
@yaswanthsaivendra
Merge branch 'coronasafe:master' into master
d2134a9
@yaswanthsaivendra
used prefetch where we are querying the skills using UserAssigned Ser…
7000a38 
…ializer
@yaswanthsaivendra
made neccessary changes to filter for having admitted but no bed assi…
5fbe144 
…gned
@yaswanthsaivendra
Revert "used prefetch where we are querying the skills using UserAssi…
719129e 
…gned Serializer"

This reverts commit 7000a38.
@yaswanthsaivendra
updated the view to handle none option for bed type
f201c9b
@yaswanthsaivendra yaswanthsaivendra requested a review from a team as a code owner May 27, 2023 18:50
@rithviknishad rithviknishad linked an issue May 28, 2023 that may be closed by this pull request
Patient filter: Add None option for Last admitted to Bed filter to filter patients that are admitted but has no bed assigned #1184
Closed
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 11.11% and project coverage change: -0.05 ⚠️

Comparison is base (7d14e41) 56.71% compared to head (f201c9b) 56.67%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1318      +/-   ##
==========================================
- Coverage   56.71%   56.67%   -0.05%     
==========================================
  Files         199      199              
  Lines        9905     9914       +9     
  Branches     1654     1656       +2     
==========================================
+ Hits         5618     5619       +1     
- Misses       4232     4240       +8     
  Partials       55       55
Impacted Files Coverage Δ
care/facility/api/viewsets/patient.py 50.90% <11.11%> (-1.34%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gigincg
Copy link
Member

gigincg commented May 29, 2023

cc: @yaswanthsaivendra

@sonarcloud
Copy link

sonarcloud bot commented May 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sainak
sainak requested changes Jun 1, 2023
View reviewed changes
care/facility/api/viewsets/patient.py Outdated Show resolved Hide resolved
sainak
sainak requested changes Jun 7, 2023
View reviewed changes
care/facility/api/viewsets/patient.py Outdated Show resolved Hide resolved
@yaswanthsaivendra
Copy link
Contributor Author

@vigneshhari @sainak @rithviknishad Added tests , Please Review!!

@sainak
Merge branch 'master' into none
b581a8a
@sainak
minor refactor
6056779 
Signed-off-by: Aakash Singh <mail@singhaakash.dev>
@sainak
add more tests
536ab30 
Signed-off-by: Aakash Singh <mail@singhaakash.dev>
@nihal467
Copy link
Member

LGTM, @vigneshhari can you review it, don't merge it this week

@nihal467
Copy link
Member

nihal467 commented Sep 11, 2023 •
edited
Loading

@vigneshhari can you review and merge it, we are planning to close it this week

@vigneshhari vigneshhari merged commit b0a7cc8 into ohcnetwork:master Sep 11, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sainak sainak sainak approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@vigneshhari vigneshhari vigneshhari approved these changes

Assignees
No one assigned
Labels
reviewed
Projects
None yet
Milestone
No milestone
7 participants
@yaswanthsaivendra @codecov-commenter @gigincg @nihal467 @vigneshhari @rithviknishad @sainak