Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows only State Admin users to delete other users #1341

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

rithviknishad
Copy link
Member

Associated Issue

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (96222fc) 56.71% compared to head (f33788c) 56.73%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1341      +/-   ##
==========================================
+ Coverage   56.71%   56.73%   +0.01%     
==========================================
  Files         199      199              
  Lines        9905     9903       -2     
  Branches     1654     1653       -1     
==========================================
  Hits         5618     5618              
+ Misses       4232     4231       -1     
+ Partials       55       54       -1     
Impacted Files Coverage Δ
care/users/api/viewsets/users.py 52.27% <0.00%> (+0.58%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vigneshhari vigneshhari merged commit 0cbff7c into master Jun 6, 2023
@sainak sainak deleted the state-admin-only-delete-user branch June 6, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow only state admin users to delete other users
3 participants