Adds validation to consulation date fields (admission_date, discharge_date, death_datetime)
#1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigneshhari
approved these changes
Jun 27, 2023
sainak
approved these changes
Jul 1, 2023
|
@rithviknishad Need to fix tests. |
sainak
approved these changes
Jul 5, 2023
vigneshhari
approved these changes
Jul 5, 2023
vigneshhari
approved these changes
Jul 5, 2023
| @@ -136,7 +137,7 @@ def test_user_can_read_all(self): | |||
| self.assertEqual(response.status_code, status.HTTP_200_OK) | |||
| res_data_json = response.json() | |||
| # test total user count | |||
| self.assertEqual(res_data_json["count"], 2) # 2 existing, plus the new one | |||
| self.assertEqual(res_data_json["count"], 3) # 3 existing, plus the new one | |||
There was a problem hiding this comment.
instead of hardcoding 3, we can fetch that value from the database. maybe in a separate ticket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
admission_date: disallow future.discharge_date: disallow future and disallow beforeadmission_datedeath_datetime: disallow future and disallow beforeadmission_dateAssociated Issue
discharge_dateadmission_dateanddeath_datetime#1404Merge Checklist
/docsOnly PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins