Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ruff for lint and format #1559

Merged
merged 5 commits into from
Sep 22, 2024
Merged

Switch to ruff for lint and format #1559

merged 5 commits into from
Sep 22, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Aug 25, 2023

Proposed Changes

  • use ruff for formatting and linting
  • update ci
  • update precommit hooks
  • cleanup gitignore

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@vigneshhari
Copy link
Member

Make sure you add some make commands that lint currently staged and all files ( both with and without docker )

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.19%. Comparing base (22a91f9) to head (1482a7b).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1559   +/-   ##
========================================
  Coverage    65.19%   65.19%           
========================================
  Files          242      242           
  Lines        13866    13866           
  Branches      1925     1925           
========================================
  Hits          9040     9040           
  Misses        4448     4448           
  Partials       378      378           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sainak sainak added to-be-closed PRs with no updates in the last 3 weeks will be closed and removed to-be-closed PRs with no updates in the last 3 weeks will be closed labels May 12, 2024
@sainak sainak requested a review from a team as a code owner May 15, 2024 20:02
@sainak sainak marked this pull request as draft May 15, 2024 20:02
@sainak
Copy link
Member Author

sainak commented May 15, 2024

TODO:

  • reverify the rules
  • cleanup vscode settings

@bodhish
Copy link
Member

bodhish commented Sep 19, 2024

@sainak if you are not planing to work on it, lets close the PR

@sainak
Copy link
Member Author

sainak commented Sep 19, 2024

@sainak if you are not planing to work on it, lets close the PR

I'll finish this up by tomorrow, waiting for #2449

@sainak sainak marked this pull request as ready for review September 22, 2024 10:18
@sainak sainak changed the title feat: use ruff Switch to ruff for lint and format Sep 22, 2024
@sainak sainak requested review from vigneshhari and rithviknishad and removed request for mathew-alex September 22, 2024 10:44
@vigneshhari vigneshhari merged commit d4f9208 into develop Sep 22, 2024
4 of 5 checks passed
@vigneshhari vigneshhari deleted the sainak/feat/ruff branch September 22, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to ruff for formatting and linting
4 participants