Added AssetPublicQRViewSet to handle QR code based asset retrieval
#1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master coronasafe/care_fe#1625 +/- ##
==========================================
+ Coverage 59.08% 59.19% +0.10%
==========================================
Files 205 205
Lines 11145 11175 +30
Branches 1587 1591 +4
==========================================
+ Hits 6585 6615 +30
Misses 4360 4360
Partials 200 200
☔ View full report in Codecov by Sentry. |
|
@Ashesh3 add tests for the retrieve method |
Added |
|
You also need to create a signal to delete the cache when an asset updates, need tests for that edge as well. |
@vigneshhari added, could you review? |
sainak
approved these changes
Sep 19, 2023
rithviknishad
approved these changes
Sep 21, 2023
vigneshhari
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new viewset,
AssetPublicQRViewSet, which allows the retrieval of assets using their QR code identifiers. The viewset checks if the provided identifier is a UUID or the primary key of the asset. If the identifier is not found in the cache, the asset is retrieved from the database, serialized, and stored in the cache for future requests. This update also includes the registration of the new viewset in the API router under the public endpoints.Required for: ohcnetwork/10bedicu#82
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins