Ensure Deterministic Ordering of Local Self Government and Ward Data #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1665 +/- ##
==========================================
- Coverage 60.76% 60.75% -0.02%
==========================================
Files 210 210
Lines 11531 11533 +2
Branches 1642 1644 +2
==========================================
Hits 7007 7007
- Misses 4283 4285 +2
Partials 241 241 ☔ View full report in Codecov by Sentry. |
Ashesh3
requested review from
vigneshhari,
rithviknishad,
khavinshankar and
sainak
rithviknishad
approved these changes
Oct 25, 2023
|
@sainak need review |
sainak
approved these changes
Nov 7, 2023
|
@vigneshhari could you review this? |
vigneshhari
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ohcnetwork/care_fe#6735
In this PR, we have made changes to ensure that the Local Self Government (LSG) and Ward data are always processed in a deterministic order. This is achieved by sorting the data based on the 'name' and 'localbody_code' before it's inserted into the database. This ensures that regardless of the order in which the data is read from the JSON files, it will always be inserted into the database in the same order.
Additionally, we have also sorted the list of JSON files before processing them. This ensures that the files are always processed in the same order.
These changes help in maintaining consistency and predictability when dealing with LSG and Ward data and can be particularly useful in scenarios where the order of data matters.
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins