ICD-11 diagnosis cannot be both provisional and final #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1673 +/- ##
==========================================
+ Coverage 60.02% 60.17% +0.14%
==========================================
Files 208 208
Lines 11319 11321 +2
Branches 1606 1607 +1
==========================================
+ Hits 6794 6812 +18
+ Misses 4301 4289 -12
+ Partials 224 220 -4
☔ View full report in Codecov by Sentry. |
rithviknishad
requested changes
Oct 15, 2023
rithviknishad
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
@sainak should we move the loading of icd11 to in-memory for tests to somewhere else?
or is it fine for now since we'll soon rewrite how we populate icd11/medibase to in memory in the first place?
sainak
approved these changes
Oct 20, 2023
its fine for now |
|
lgtm @vigneshhari can you review it |
|
The model changes from #1690 will naturally solve the related issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Associated Issue
Merge Checklist
/docsOnly PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins