Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offload migrations to beat service #1710

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Conversation

sainak
Copy link
Member

@sainak sainak commented Nov 13, 2023

Proposed Changes

  • offload migrations to beat service

Architecture changes

  • let celery beat service take care of the migrations to avoid race conditons in the case of multiple backed replicas

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@sainak sainak force-pushed the sainak/fix/migrations branch 2 times, most recently from 35c2cd6 to ab275a5 Compare November 21, 2023 21:14
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (033d085) 60.75% compared to head (06c893d) 60.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1710   +/-   ##
=======================================
  Coverage   60.75%   60.75%           
=======================================
  Files         210      210           
  Lines       11533    11533           
  Branches     1644     1644           
=======================================
  Hits         7007     7007           
  Misses       4285     4285           
  Partials      241      241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

scripts/celery_beat.sh Outdated Show resolved Hide resolved
@vigneshhari vigneshhari merged commit df576b0 into master Dec 7, 2023
8 checks passed
@vigneshhari vigneshhari deleted the sainak/fix/migrations branch December 7, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants