Enhanced Error Handling in AssetViewSet #1737
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
In this commit, two key changes were made to the
operate_assets
function withinviewsets/asset.py
. The modifications enhance error reporting and provide clearer error messages for the user.Detailed Validation Error Message:
In case of a
ValidationError
, the key 'message' in the response dictionary was renamed to 'detail', ensuring consistent terminology across all responses.Improved APIException Handling:
The previous implemention simply returned the exception's
detail
andstatus_code
. Now, it's refactored to a more informative error message when communication with the middleware fails. A new status (HTTP_424_FAILED_DEPENDENCY) is returned to signify that the failure is due to an unmet dependency, providing better context on the nature of the error.The frontend expects the error to be sent in
detail
key for4xx
errors.https://github.com/coronasafe/care_fe/blob/develop/src/Redux/fireRequest.tsx#L152-L164
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins