Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resolved_middleware JSON field to Asset Serializer. #1741

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

rithviknishad
Copy link
Member

Proposed Changes

  • Adds a serializer method field: resolved_middleware that returns a JSON of the resolved middleware.
image

Examples

image image image

Associated Issue

Architecture changes

  • Remove this section if not used

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (8bdbb42) 60.76% compared to head (67f1789) 60.75%.
Report is 1 commits behind head on master.

❗ Current head 67f1789 differs from pull request most recent head 97a8bd6. Consider uploading reports for the commit 97a8bd6 to get more accurate results

Files Patch % Lines
care/facility/models/asset.py 37.50% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1741      +/-   ##
==========================================
- Coverage   60.76%   60.75%   -0.01%     
==========================================
  Files         210      210              
  Lines       11531    11546      +15     
  Branches     1642     1649       +7     
==========================================
+ Hits         7007     7015       +8     
- Misses       4283     4288       +5     
- Partials      241      243       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sainak sainak added P1 High priority; urgent and removed P1 High priority; urgent labels Dec 7, 2023
@vigneshhari vigneshhari merged commit 79c734a into master Dec 7, 2023
8 of 9 checks passed
@vigneshhari vigneshhari deleted the resolved-middleware-serializer-method-field branch December 7, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asset serializer: Add serializer method field resolved_middleware.
4 participants