Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor asset status check logic #1750

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Refactor asset status check logic #1750

merged 1 commit into from
Dec 7, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Dec 7, 2023

Proposed Changes

  • Remove caching and asset grouping during uptime check as per EOD call; in order to simplify the override process during uptime monitoring.

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (033d085) 60.75% compared to head (e7d38f6) 60.83%.

Files Patch % Lines
care/facility/tasks/asset_monitor.py 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1750      +/-   ##
==========================================
+ Coverage   60.75%   60.83%   +0.07%     
==========================================
  Files         210      210              
  Lines       11533    11517      -16     
  Branches     1644     1640       -4     
==========================================
- Hits         7007     7006       -1     
+ Misses       4285     4270      -15     
  Partials      241      241              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sainak sainak added the P1 High priority; urgent label Dec 7, 2023
@vigneshhari vigneshhari merged commit 1489801 into master Dec 7, 2023
10 of 11 checks passed
@vigneshhari vigneshhari deleted the uptime-override branch December 7, 2023 17:38
Copy link

sentry-io bot commented Dec 7, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ SSLError: HTTPSConnectionPool(host='dev_middle.ware.com', port=443): Max retries exceeded with url: /camera... care.facility.tasks.asset_monitor.check_asset_s... View Issue
  • ‼️ ConnectionError: HTTPSConnectionPool(host='dev_middleware.coronasafe.live', port=443): Max retries exceeded with u... care.facility.tasks.asset_monitor.check_asset_s... View Issue
  • ‼️ ConnectionError: HTTPSConnectionPool(host='test', port=443): Max retries exceeded with url: /cameras/status (Cause... care.facility.tasks.asset_monitor.check_asset_s... View Issue
  • ‼️ APIException: care.facility.tasks.asset_monitor.check_asset_s... View Issue
  • ‼️ ConnectionError: ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer')) care.facility.tasks.asset_monitor.check_asset_s... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority; urgent waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants