Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bucket configurations #1826

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Fix bucket configurations #1826

merged 3 commits into from
Jan 17, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Jan 16, 2024

Proposed Changes

  • make bucket configurations more flexible
  • add variable for external endpoints for buckets
  • fix localstack container

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (662e0c5) 61.52% compared to head (39c85b8) 61.57%.

Files Patch % Lines
care/facility/models/file_upload.py 66.66% 5 Missing ⚠️
care/utils/csp/config.py 73.68% 3 Missing and 2 partials ⚠️
care/facility/api/serializers/facility.py 33.33% 2 Missing ⚠️
care/facility/models/facility.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1826      +/-   ##
==========================================
+ Coverage   61.52%   61.57%   +0.05%     
==========================================
  Files         208      208              
  Lines       11542    11556      +14     
  Branches     1649     1649              
==========================================
+ Hits         7101     7116      +15     
+ Misses       4151     4149       -2     
- Partials      290      291       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vigneshhari vigneshhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some documentation to get it working with GCloud would be good now that we removed the explicit option.

@vigneshhari vigneshhari merged commit 7d0dd82 into master Jan 17, 2024
11 checks passed
@vigneshhari vigneshhari deleted the sainak/fix/localstack branch January 17, 2024 11:09
Copy link

sentry-io bot commented Jan 23, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ **ValueError: Invalid endpoint: ** care.facility.tasks.discharge_summary.generate_... View Issue
  • ‼️ **ValueError: Invalid endpoint: ** /api/v1/files/ View Issue
  • ‼️ **ValueError: Invalid endpoint: ** /api/v1/files/{external_id}/ View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants