Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExternalIDSerializerField to be UUID Field instead of Field #1958

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Mar 10, 2024

Proposed Changes

  • ExternalIDSerializerField to be UUID Field instead of Field

Associated Issue

Before

image

After

image

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.19%. Comparing base (bd161ef) to head (d24242a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1958   +/-   ##
=======================================
  Coverage   62.19%   62.19%           
=======================================
  Files         221      221           
  Lines       12203    12203           
  Branches     1742     1742           
=======================================
  Hits         7590     7590           
  Misses       4305     4305           
  Partials      308      308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vigneshhari vigneshhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Catch!

@vigneshhari vigneshhari merged commit 114c643 into develop Mar 17, 2024
11 checks passed
@vigneshhari vigneshhari deleted the fixes-1957 branch March 17, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings for ExternalIdSerializerField
4 participants