-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrating feature field to array field #2223
migrating feature field to array field #2223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove old_features in a later pr
care/facility/migrations/0438_rename_features_facility_old_features.py
Outdated
Show resolved
Hide resolved
care/facility/migrations/0438_rename_features_facility_old_features.py
Outdated
Show resolved
Hide resolved
…n-facility-model' into updating-feature-to-arrayfield-in-facility-model
@sainak made all the required changes, please take a look |
care/facility/migrations/0438_rename_features_facility_old_features.py
Outdated
Show resolved
Hide resolved
care/facility/migrations/0438_rename_features_facility_old_features.py
Outdated
Show resolved
Hide resolved
@sainak @rithviknishad made the changes , can you please run the workflows to check if everything's alright? |
care/facility/migrations/0445_rename_features_facility_old_features.py
Outdated
Show resolved
Hide resolved
updated. Should be fine now. |
@rithviknishad @sainak I've fixed the errors , updated the migration file name and dependencies , also fixed the static dummy data from facility.json |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2223 +/- ##
===========================================
+ Coverage 63.82% 63.85% +0.02%
===========================================
Files 239 239
Lines 13416 13435 +19
Branches 1909 1913 +4
===========================================
+ Hits 8563 8579 +16
- Misses 4505 4508 +3
Partials 348 348 ☔ View full report in Codecov by Sentry. |
Proposed Changes
Migrations sequence -
Associated Issue
Facility.features
to ArrayField #2215Merge Checklist
/docs
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins