Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrating feature field to array field #2223

Conversation

DraKen0009
Copy link
Contributor

@DraKen0009 DraKen0009 commented Jun 3, 2024

Proposed Changes

Migrations sequence -

  • renamed feature to old_feature
  • added a feature field with array field
  • copied data from old_feature field to feature field
  • deleted old_feature field

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@DraKen0009 DraKen0009 requested a review from a team as a code owner June 3, 2024 06:40
Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove old_features in a later pr

care/facility/api/serializers/facility.py Show resolved Hide resolved
care/facility/models/facility.py Outdated Show resolved Hide resolved
@DraKen0009
Copy link
Contributor Author

@sainak made all the required changes, please take a look

@DraKen0009 DraKen0009 requested a review from sainak June 7, 2024 08:14
@DraKen0009
Copy link
Contributor Author

@sainak @rithviknishad made the changes , can you please run the workflows to check if everything's alright?

@DraKen0009
Copy link
Contributor Author

updated. Should be fine now.

@DraKen0009
Copy link
Contributor Author

@rithviknishad @sainak I've fixed the errors , updated the migration file name and dependencies , also fixed the static dummy data from facility.json

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.85%. Comparing base (c1a74f2) to head (fe4994f).
Report is 5 commits behind head on develop.

Files Patch % Lines
care/facility/models/facility.py 81.25% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2223      +/-   ##
===========================================
+ Coverage    63.82%   63.85%   +0.02%     
===========================================
  Files          239      239              
  Lines        13416    13435      +19     
  Branches      1909     1913       +4     
===========================================
+ Hits          8563     8579      +16     
- Misses        4505     4508       +3     
  Partials       348      348              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigneshhari vigneshhari merged commit 1038f99 into ohcnetwork:develop Aug 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert Facility.features to ArrayField
4 participants