Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched Static Files in Care to WhiteNoise #724

Merged
merged 5 commits into from
May 26, 2022
Merged

Switched Static Files in Care to WhiteNoise #724

merged 5 commits into from
May 26, 2022

Conversation

sainak
Copy link
Member

@sainak sainak commented Apr 23, 2022

closes #689

@sainak sainak changed the title removed collectfast as its not supported by whitenoise Switched Static Files in Care to WhiteNoise Apr 23, 2022
@sainak sainak marked this pull request as ready for review April 26, 2022 06:11
@sainak sainak requested a review from a team as a code owner April 26, 2022 06:11
@vigneshhari
Copy link
Member

This PR requires a rebuild of the requirements base image, Will merge this next week.

@gitguardian
Copy link

gitguardian bot commented May 20, 2022

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@sainak sainak mentioned this pull request May 20, 2022
@sainak
Copy link
Member Author

sainak commented May 25, 2022

This should be good to merge as now we are using a single docker image.

Copy link
Contributor

@Marmik2003 Marmik2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

@vigneshhari vigneshhari merged commit c64d2a6 into ohcnetwork:master May 26, 2022
@sainak sainak deleted the issue-689 branch May 28, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch Static Files in Care to WhiteNoise
3 participants