Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the meta field optional in Asset & Bed Tables #769

Merged
merged 9 commits into from
Jun 19, 2022
Merged

Make the meta field optional in Asset & Bed Tables #769

merged 9 commits into from
Jun 19, 2022

Conversation

rabilrbl
Copy link
Contributor

Made meta field optional in Asset & Bed Tables

Closes #765

@rabilrbl rabilrbl requested a review from a team as a code owner May 20, 2022 03:54
@gitguardian
Copy link

gitguardian bot commented May 20, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Generic Private Key 613009a config/settings/base.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@vigneshhari
Copy link
Member

are you sure this wont break the fronend?

care/facility/models/asset.py Outdated Show resolved Hide resolved
care/facility/models/bed.py Outdated Show resolved Hide resolved
care/facility/models/bed.py Outdated Show resolved Hide resolved
care/facility/models/bed.py Outdated Show resolved Hide resolved
@rabilrbl rabilrbl requested a review from sainak May 27, 2022 17:19
@sainak
Copy link
Member

sainak commented May 27, 2022

@rabilrbl recreate the migrations

Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sainak sainak requested a review from vigneshhari May 27, 2022 18:13
@vigneshhari vigneshhari changed the base branch from master to temporay_master June 19, 2022 12:49
@vigneshhari vigneshhari merged commit d8429f9 into ohcnetwork:temporay_master Jun 19, 2022
@vigneshhari
Copy link
Member

There is something wrong with the migrations, moving to temporary branch to test and push to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the meta field optional in all Asset & Bed Tables
3 participants