Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow DELETE method for bed endpoint #815

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Allow DELETE method for bed endpoint #815

merged 1 commit into from
Jun 6, 2022

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Jun 3, 2022 •
edited
Loading

Basically allows bed to be deleted. Adds the DestroyModelMixin to the BedViewSet and custom define the destroy method

@Ashesh3 Ashesh3 requested a review from a team as a code owner June 3, 2022 14:23
@Ashesh3 Ashesh3 mentioned this pull request Jun 3, 2022
Merged
@sainak sainak changed the title Delete bed endpoint Allow DELETE method for bed endpoint Jun 4, 2022
Marmik2003
Marmik2003 approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@Marmik2003 Marmik2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

vigneshhari
vigneshhari approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@vigneshhari vigneshhari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Untested.

@vigneshhari vigneshhari merged commit 19dd180 into ohcnetwork:master Jun 6, 2022
@Ashesh3 Ashesh3 deleted the bed-delete branch June 6, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marmik2003 Marmik2003 Marmik2003 approved these changes

@vigneshhari vigneshhari vigneshhari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ashesh3 @vigneshhari @Marmik2003