Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: disable none volunteers assigning #2696

Closed
wants to merge 4 commits into from

Conversation

kunatastic
Copy link
Contributor

@kunatastic kunatastic commented Jun 13, 2022

closes #2695 and #2771

Updation
image

@kunatastic kunatastic requested a review from a team June 13, 2022 05:19
@kunatastic kunatastic requested a review from a team as a code owner June 13, 2022 05:19
@vercel
Copy link

vercel bot commented Jun 13, 2022

@kunatastic is attempting to deploy a commit to the Coronasafe Team on Vercel.

A member of the Team first needs to authorize it.

@netlify
Copy link

netlify bot commented Jun 13, 2022

Deploy Preview Failed. CC: @rithviknishad

Name Link
🔨 Latest commit 5f22fe3
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/62a6c8fbd998c80008d36564

@vercel
Copy link

vercel bot commented Jun 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-fe ❌ Failed (Inspect) Jun 19, 2022 at 5:25PM (UTC)

Copy link
Contributor

@patelaryan7751 patelaryan7751 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@arpancodes arpancodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may not want to show the ✔️ beside the last selected volunteer after we clear? even after changing the volunteer...

we may use something else like a background colour to show it was last selected... the ✔️ gives an impression that it is already selected but the form won't submit.

@kunatastic
Copy link
Contributor Author

Also #2771 has been resolved in same PR

@nihal467
Copy link
Member

@kunatastic test failed,

if i assign a volunteer to a patient once, and it unable to unassign the patient from volunteer by clicking clear and submit button is not possible.

@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@nihal467
Copy link
Member

@kunatastic what is the PR status

@nihal467 nihal467 added the waiting for update PR is been dead for a long time label Jul 31, 2022
@mathew-alex mathew-alex added the merge conflict pull requests with merge conflict label Sep 27, 2022
@mathew-alex
Copy link
Contributor

👋 Hi, @kunatastic,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@stale stale bot removed the waiting for update PR is been dead for a long time label Sep 27, 2022
@stale
Copy link

stale bot commented Oct 8, 2022

Hi, @${author}, This pr/issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs for 7 more days. Thank you for your contributions.

@stale stale bot added the stale label Oct 8, 2022
@stale
Copy link

stale bot commented Oct 15, 2022

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex This pr/issue has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr/issue.

@stale stale bot closed this Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in assiging to a volunter
7 participants