Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamped patient details page UI #2897

Merged
merged 11 commits into from
Jul 21, 2022

Conversation

patelaryan7751
Copy link
Contributor

@patelaryan7751 patelaryan7751 commented Jun 25, 2022

Fixes #2851

Bugs Fixed

Revamped patient details page UI and changed page name to the patient details page

image

@patelaryan7751 patelaryan7751 requested a review from a team June 25, 2022 12:58
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner June 25, 2022 12:58
Copy link
Member

@aeswibon aeswibon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@nihal467
Copy link
Member

@patelaryan7751 test failed

3

It is not patient details , it is sample test history

@patelaryan7751
Copy link
Contributor Author

@nihal467 I have changed the title to Sample Test History
image
I also changed the title "Covid Suspect Detail" to "Patient Detail"
image

@nihal467
Copy link
Member

@patelaryan7751

7

  • add a white box, in that mention under-sample test history that there is no data available error message

7a

  • align the badges to the top contents

@patelaryan7751
Copy link
Contributor Author

Hey @nihal467 I have made the above said changes

Added a white box for both sample details and consultation details

image

Aligned all badges in patient card

Screenshot from 2022-07-06 11-06-31

@nihal467
Copy link
Member

nihal467 commented Jul 6, 2022

@patelaryan7751
30

Add District too, because in Manipur, the local body doesn't mention the district name, as we have in Kerala

@patelaryan7751
Copy link
Contributor Author

Hey, @nihal467 added district in location card
image

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar added the merge conflict pull requests with merge conflict label Jul 13, 2022
@patelaryan7751 patelaryan7751 removed the merge conflict pull requests with merge conflict label Jul 14, 2022
@khavinshankar khavinshankar merged commit 81ab7df into ohcnetwork:develop Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp Patient Detail Page
5 participants