Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added close and currect location select buttons in GLocationPicker #3817

Merged
merged 6 commits into from
Nov 17, 2022
Merged

Added close and currect location select buttons in GLocationPicker #3817

merged 6 commits into from
Nov 17, 2022

Conversation

khavinshankar
Copy link
Member

Proposed Changes

  • Added custom custom to close gmap
  • Added custom button to select current location

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@khavinshankar khavinshankar requested a review from a team October 24, 2022 03:52
@khavinshankar khavinshankar requested a review from a team as a code owner October 24, 2022 03:52
@netlify
Copy link

netlify bot commented Oct 24, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit bedd78f
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63748bd66f1ea3000817d12a
😎 Deploy Preview https://deploy-preview-3817--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@khavinshankar khavinshankar linked an issue Oct 24, 2022 that may be closed by this pull request
Add current Location and close button in the facility creation page map #3746
Closed
2 tasks
@nihal467
Copy link
Member

@khavinshankar
image

iam getting a something went wrong error in this PR, when gps location is not added

@nihal467
Copy link
Member

nihal467 commented Oct 26, 2022 •
edited by khavinshankar
Loading

@khavinshankar
image

  • when we are opening the create facility page, the current location of the system are been auto filed, before even we are clicking the locate icon

image

  • the search bar is covering the whole map, now, unable to see the map

@vercel
Copy link

vercel bot commented Oct 26, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 7:07AM (UTC)

@khavinshankar
Copy link
Member Author

image

  • the search bar is covering the whole map, now, unable to see the map

@nihal467 This is working fine in the local, this issue is caused due to permission error,
@mathew-alex can you please check this out
image

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 3, 2022
@mathew-alex
Copy link
Contributor

mathew-alex commented Nov 9, 2022 •
edited
Loading

@khavinshankar, @nihal467 - permissions updated
Screenshot 2022-11-09 at 10 31 58 PM

@nihal467
Copy link
Member

nihal467 commented Nov 10, 2022 •
edited by khavinshankar
Loading

@khavinshankar
image

  • Currently, there is no way to get to our current location,

image

  • add something like the current location icon in the map, so that the user can click on it to track the current location

image

  • when we click on the button, our location details are not getting auto-filled in the longitude and latitude column

@khavinshankar
Copy link
Member Author

@nihal467 the icon on the top left is used to get the current location
image

@nihal467
Copy link
Member

@khavinshankar the button is not working

@khavinshankar
Copy link
Member Author

@khavinshankar the button is not working

@nihal467 can you try it in incognito, it seems to be working fine

@nihal467 nihal467 mentioned this pull request Nov 11, 2022
Closed
@Pranshu1902
Copy link
Contributor

Also Fixes #1095

@sainak sainak linked an issue Nov 13, 2022 that may be closed by this pull request
Lat/Long not getting updated in Facility update ohcnetwork/care#1095
Closed
@nihal467
Copy link
Member

@khavinshankar
image

can you take care of the responsive issue

@sonarcloud
Copy link

sonarcloud bot commented Nov 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

test approved

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Nov 16, 2022
@khavinshankar khavinshankar removed the cypress failed pull request with cypress test failure label Nov 17, 2022
@gigincg gigincg merged commit 4f513bf into develop Nov 17, 2022
@gigincg gigincg deleted the feat#3746 branch November 17, 2022 15:30
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@khavinshankar @aeswibon
Added close and currect location select buttons in GLocationPicker (o…
be3a07b 
…hcnetwork#3817)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
5 participants
@khavinshankar @nihal467 @mathew-alex @Pranshu1902 @gigincg