Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched to CARE UI components in facility tiles #4159

Merged
merged 19 commits into from
Jan 6, 2023
Merged

Conversation

shivankacker
Copy link
Member

@shivankacker shivankacker commented Dec 1, 2022

Proposed Changes

After:
image

Before:
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shivankacker shivankacker requested a review from a team December 1, 2022 11:23
@shivankacker shivankacker requested a review from a team as a code owner December 1, 2022 11:23
@vercel
Copy link

vercel bot commented Dec 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Jan 5, 2023 at 2:22PM (UTC)

@netlify
Copy link

netlify bot commented Dec 1, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c07fd2c
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63b6dc9b71588b0009982e77
😎 Deploy Preview https://deploy-preview-4159--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Dec 1, 2022
Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 1, 2022
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

👋 Hi, @skks1212,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad
Copy link
Member

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Dec 2, 2022
@shivankacker shivankacker removed hold cypress failed pull request with cypress test failure labels Dec 2, 2022
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Dec 2, 2022
@github-actions
Copy link

github-actions bot commented Dec 3, 2022

👋 Hi, @skks1212,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 3, 2022
@shivankacker shivankacker removed the merge conflict pull requests with merge conflict label Dec 6, 2022
@nihal467
Copy link
Member

nihal467 commented Dec 6, 2022

@skks1212
image

  • in the responsive view, the buttons are inconsistent
  • the buttons are not showing the complete text in responsive view

@nihal467
Copy link
Member

nihal467 commented Dec 6, 2022

@skks1212 marking it for team discussion required for discussing some points

photo-2

  • reverting back to font-awesome icons
  • the icon of notify button are been changed
  • the size of badges are been reduced

@shivankacker shivankacker removed the cypress failed pull request with cypress test failure label Dec 27, 2022
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Dec 27, 2022
@khavinshankar
Copy link
Member

@skks1212 can you take off the failing cypress tests, most likely merging the latest develop branch should fix it

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 28, 2022
@github-actions
Copy link

👋 Hi, @skks1212,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Dec 28, 2022
@shivankacker
Copy link
Member Author

@khavinshankar tests keep failing, can't figure out why : (

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jan 4, 2023
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

👋 Hi, @skks1212,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Jan 4, 2023
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

👋 Hi, @skks1212,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jan 4, 2023
@khavinshankar
Copy link
Member

@skks1212 the remaining failing cypress tests should be fixed once auto-update is merged, so can you just handle the merge conflicts

cc: @nihal467

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Jan 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

@khavinshankar khavinshankar merged commit 575cd92 into develop Jan 6, 2023
@sainak sainak deleted the cui-fac-list branch January 19, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uneven padding of chips in facility tiles
4 participants