Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made verified by field in consultation required #4295

Merged
merged 4 commits into from
Dec 17, 2022

Conversation

shivankacker
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shivankacker shivankacker requested a review from a team December 13, 2022 08:42
@shivankacker shivankacker requested a review from a team as a code owner December 13, 2022 08:42
@vercel
Copy link

vercel bot commented Dec 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 17, 2022 at 9:17AM (UTC)

@netlify
Copy link

netlify bot commented Dec 13, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 07b479e
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/639d88ceb6fa2300080e74ee
😎 Deploy Preview https://deploy-preview-4295--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shivankacker shivankacker added needs testing P1 breaking issue or vital feature labels Dec 13, 2022
@nihal467
Copy link
Member

@skks1212
image

I am able to submit the consultation form without filling the verified by data

@nihal467
Copy link
Member

@shivankacker
Copy link
Member Author

@nihal467 seems to be working for me 🤔🤔
image

I added a few more checks, can you test again?

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar added the question Further information is requested label Dec 16, 2022
Co-authored-by: Khavin Shankar <khavinshankar@gmail.com>
@shivankacker shivankacker removed the question Further information is requested label Dec 17, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar khavinshankar merged commit 8bb5c0a into develop Dec 17, 2022
@sainak sainak deleted the verified-important branch January 19, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Verified By in Consultation Page as mandatory field
3 participants