Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed responsive bug in asset details #4510

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Fixed responsive bug in asset details #4510

merged 1 commit into from
Jan 5, 2023

Conversation

shivankacker
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shivankacker shivankacker requested a review from a team January 4, 2023 13:59
@shivankacker shivankacker requested a review from a team as a code owner January 4, 2023 13:59
@vercel
Copy link

vercel bot commented Jan 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Jan 4, 2023 at 1:59PM (UTC)

@netlify
Copy link

netlify bot commented Jan 4, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 2f91b2d
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63b5865ca2675c000837f40b
😎 Deploy Preview https://deploy-preview-4510--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jan 4, 2023
@nihal467
Copy link
Member

nihal467 commented Jan 5, 2023 •
edited
Loading

LGTM @skks1212 @khavinshankar check out the cypress failed

@khavinshankar khavinshankar merged commit 586f6a8 into develop Jan 5, 2023
@sainak sainak deleted the asset-responsive branch January 19, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Asset detail page is not properly responsive
3 participants
@shivankacker @nihal467 @khavinshankar