Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option for declare death in decision after consultation #4518

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

shivankacker
Copy link
Member

@shivankacker shivankacker commented Jan 5, 2023

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@vercel
Copy link

vercel bot commented Jan 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Jan 5, 2023 at 2:38PM (UTC)

@netlify
Copy link

netlify bot commented Jan 5, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c481c28
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63b6e0e89ec8f20008ee35f0
😎 Deploy Preview https://deploy-preview-4518--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Jan 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jan 5, 2023
@nihal467
Copy link
Member

nihal467 commented Jan 11, 2023

@skks1212 don't work on the below comments until it is discussed in today's (11/01/2023) EOD

@aparnacoronasafe comment your opinion on the below points :

image

  • even though I mark a patient in the consultation form as declared dead, the particular patient consultation page, is still active. I think, once a patient is declared dead in a consultation form, the particular patient consultation page should be inactive and we should be able to generate a death report.

image

  • shall we remove the expired option from the droplist on the patient creation form, as there is no need for it, as we are capturing it from the consultation page now?

image

  • when a patient is declared dead, we should be having a field cause of death in the create consultation page

Marking it for team discussion required for discussing above points

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 94c3a5a into develop Jan 12, 2023
@sainak sainak deleted the declare-death branch January 19, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Declare death
3 participants