Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added skills in doctor connect #4772

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Added skills in doctor connect #4772

merged 1 commit into from
Feb 7, 2023

Conversation

khavinshankar
Copy link
Member

Proposed Changes

cc: @aparnacoronasafe @nihal467

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@khavinshankar khavinshankar added needs testing P1 breaking issue or vital feature labels Feb 6, 2023
@khavinshankar khavinshankar requested a review from a team February 6, 2023 07:37
@khavinshankar khavinshankar requested a review from a team as a code owner February 6, 2023 07:37
@vercel
Copy link

vercel bot commented Feb 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Feb 6, 2023 at 7:37AM (UTC)

@netlify
Copy link

netlify bot commented Feb 6, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 258d300
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63e0ae2f1faab400089360c4
😎 Deploy Preview https://deploy-preview-4772--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Feb 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Feb 6, 2023
@nihal467
Copy link
Member

nihal467 commented Feb 6, 2023

LGTM

bodhish
bodhish approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bodhish bodhish merged commit 2d3bcda into develop Feb 7, 2023
@sainak sainak deleted the fix#4770 branch February 21, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@bodhish bodhish bodhish approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure P1 breaking issue or vital feature tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skills to be visible on Doctor Connect Panel
4 participants
@khavinshankar @nihal467 @bodhish @rithviknishad