Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesigned count block #4818

Merged
merged 8 commits into from
Mar 14, 2023
Merged

Redesigned count block #4818

merged 8 commits into from
Mar 14, 2023

Conversation

shivankacker
Copy link
Member

@shivankacker shivankacker commented Feb 14, 2023 •
edited
Loading

Proposed Changes

After:
image

Before:
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shivankacker shivankacker requested a review from a team February 14, 2023 14:09
@shivankacker shivankacker requested a review from a team as a code owner February 14, 2023 14:09
@vercel
Copy link

vercel bot commented Feb 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 13, 2023 at 3:51PM (UTC)

@netlify
Copy link

netlify bot commented Feb 14, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 95ced07
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/640f45ef90957f00081dbdf2
😎 Deploy Preview https://deploy-preview-4818--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Feb 14, 2023
@nihal467
Copy link
Member

nihal467 commented Feb 20, 2023 •
edited
Loading

@skks1212
image

image

all the components are having rectangle curved padding, which gives a uniform feel, having data, is shown without padding on a whole page, which feels like losing consistency. Marking it for discussion

@nihal467
Copy link
Member

@skks1212 add the padding to the whole page

@github-actions
Copy link

👋 Hi, @skks1212,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Feb 27, 2023
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Feb 28, 2023
@nihal467
Copy link
Member

nihal467 commented Mar 5, 2023

@skks1212

image

  • remove excess white padding in the patient tab
  • merge the latest development branch

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Mar 6, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

👋 Hi, @skks1212,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@shivankacker shivankacker added needs testing and removed work-in-progress merge conflict pull requests with merge conflict cypress failed pull request with cypress test failure labels Mar 10, 2023
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Mar 10, 2023
@nihal467
Copy link
Member

LGTM

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Mar 13, 2023
@github-actions
Copy link

👋 Hi, @skks1212,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Mar 13, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar khavinshankar merged commit 8f816e4 into develop Mar 14, 2023
@github-actions
Copy link

@skks1212 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@sainak sainak deleted the count-redesign branch February 21, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Total Patient card is not consistent
3 participants
@shivankacker @nihal467 @khavinshankar