Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added daily round symptoms to symptoms card, and updated time handling #4844

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Added daily round symptoms to symptoms card, and updated time handling #4844

merged 1 commit into from
Feb 21, 2023

Conversation

shivankacker
Copy link
Member

Proposed Changes

after:
image

before:
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shivankacker shivankacker requested a review from a team February 20, 2023 03:56
@shivankacker shivankacker requested a review from a team as a code owner February 20, 2023 03:56
@vercel
Copy link

vercel bot commented Feb 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Feb 20, 2023 at 3:56AM (UTC)

@netlify
Copy link

netlify bot commented Feb 20, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 1bb6203
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63f2ef63f1f4150007550775
😎 Deploy Preview https://deploy-preview-4844--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Feb 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Feb 20, 2023
@nihal467
Copy link
Member

@aparnacoronasafe
image

  • as per the previous discussion, we mentioned showing only the latest symptoms of the patient, and as per the PR, it will be showing symptoms during the consultation and the last updated log update. is it okay?

@aparnacoronasafe
Copy link
Member

this looks good for now. Lets go ahead

@nihal467
Copy link
Member

nihal467 commented Feb 21, 2023 •
edited
Loading

LGTM @khavinshankar @skks1212 can the failed cypress

@khavinshankar khavinshankar merged commit 573b876 into develop Feb 21, 2023
@sainak sainak deleted the symptoms-card branch February 21, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Symptoms in update section of patient consultation is malfunctioning
4 participants
@shivankacker @nihal467 @aparnacoronasafe @khavinshankar