Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix death_report_spec, facility_spec and user_spec #5573

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented May 31, 2023

WHAT

🤖 Generated by Copilot at 70a3ead

The pull request improves the test code for death report and user CRUD operations, fixes bugs and adds features to some common components, and adds name attributes to date inputs. It also sorts imports alphabetically in several files for consistency and adds data-cy attributes for testing.

Proposed Changes

  • Fix death_report_spec, facility_spec and user_spec

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 70a3ead

  • Sort imports alphabetically in cypress/e2e/death_report_spec/death_report.cy.ts, src/Components/Common/DateInputV2.tsx, src/Components/Form/FormFields/DateFormField.tsx, and src/Components/Patient/ManagePatients.tsx (link, link, link, link)
  • Use intercept and wait for API call to get patients list and click on first patient link in cypress/e2e/death_report_spec/death_report.cy.ts (link)
  • Use force option to clear and type date inputs in cypress/e2e/death_report_spec/death_report.cy.ts (link, link)
  • Add name prop to Props interface and pass it to input element in src/Components/Common/DateInputV2.tsx (link, link, link)
  • Pass name prop to DateInputV2 component in src/Components/Form/FormFields/DateFormField.tsx (link)
  • Conditionally set name attribute for phone number inputs in src/Components/Common/HelperInputFields.tsx (link, link)
  • Add data-cy attribute to patient link element in src/Components/Patient/ManagePatients.tsx (link)
  • Copy and modify code from cypress/e2e/facility_spec/facility.cy.ts to use name attribute instead of id for phone number input in cypress/e2e/death_report_spec/death_report.cy.ts (link)
  • Remove irrelevant and error-causing code for flag dropdown element in cypress/e2e/users_spec/user_crud.cy.ts (link, link, link, link)

@khavinshankar khavinshankar requested a review from a team May 31, 2023 12:14
@khavinshankar khavinshankar requested a review from a team as a code owner May 31, 2023 12:14
@vercel
Copy link

vercel bot commented May 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2023 0:33am

@netlify
Copy link

netlify bot commented May 31, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 14a5d01
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64773e7760e8950008183016
😎 Deploy Preview https://deploy-preview-5573--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label May 31, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot removed the cypress failed pull request with cypress test failure label May 31, 2023
@mathew-alex mathew-alex merged commit a1fb828 into develop Jun 1, 2023
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

@khavinshankar We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@sainak sainak deleted the fix-cypress-workflow3 branch January 19, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants