Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove legacy feed components #5868

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Conversation

sainak
Copy link
Member

@sainak sainak commented Jul 13, 2023

WHAT

🤖 Generated by Copilot at 257dfbe

Removed HubDashboard component and related code from the app. This component was not used and cluttered the app router and dashboard.

Proposed Changes

  • Remove the old live feed component which was using the middleware actions directly

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 257dfbe

  • Delete HubDashboard component and its route (link, link, link)
  • Remove unused import of HubDashboard from AppRouter component (link)

@sainak sainak requested a review from a team July 13, 2023 10:49
@sainak sainak requested a review from a team as a code owner July 13, 2023 10:49
@sainak sainak requested a review from bodhish July 13, 2023 10:49
@vercel
Copy link

vercel bot commented Jul 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2023 5:11pm

@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ed0b68c
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64ca8e19bc15880008f9606a
😎 Deploy Preview https://deploy-preview-5868--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added stale merge conflict pull requests with merge conflict labels Jul 21, 2023
@github-actions
Copy link

👋 Hi, @sainak,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the stale label Jul 26, 2023
@sainak sainak force-pushed the sainak/remove-legacy-feed branch from 257dfbe to bdb580f Compare July 31, 2023 13:09
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Jul 31, 2023
Signed-off-by: Aakash Singh <mail@singhaakash.dev>
@sainak sainak force-pushed the sainak/remove-legacy-feed branch from bdb580f to e7b2abd Compare July 31, 2023 13:10
@github-actions github-actions bot added cypress failed pull request with cypress test failure and removed cypress passed labels Jul 31, 2023
@github-actions github-actions bot added cypress passed and removed cypress failed pull request with cypress test failure labels Aug 2, 2023
@khavinshankar khavinshankar merged commit 802f5e8 into develop Aug 3, 2023
24 checks passed
@khavinshankar khavinshankar deleted the sainak/remove-legacy-feed branch August 3, 2023 07:15
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

@sainak We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants