🧹 Replace loadable package with react's built-in lazy and add top-level Suspense boundary
#6052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rithviknishad
changed the title
loadable package with react's built-in lazyloadable package with react's built-in lazy and add top-level Suspense boundary
rithviknishad
changed the title
loadable package with react's built-in lazy and add top-level Suspense boundaryloadable package with react's built-in lazy and add top-level Suspense boundary
github-actions
bot
added
cypress failed
Ashesh3
approved these changes
Aug 11, 2023
github-actions
bot
added
cypress failed
github-actions
bot
added
cypress passed
and removed
cypress failed
|
LGTM |
|
👋 Hi, @rithviknishad, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
khavinshankar
approved these changes
Aug 16, 2023
|
@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at e5f406c
This pull request replaces the
@loadable/componentlibrary with the nativeReact.lazyfunction for code splitting and lazy loading components in various files of the project. This improves the performance, maintainability, and TypeScript compatibility of the code. It also imports the correct types fromreactfor some components' props insrc/CAREUI/display.Proposed Changes
loadablepackage and use the the built-inReact.lazyinstead #6051@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at e5f406c
@loadable/componentand@types/loadable__componentdependencies and useReact.lazyinstead for code splitting and lazy loading components (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)FCandlazyfromreactand useFCtype forAppcomponent insrc/App.tsx(link)HTMLAttributesandReactNodefromreactand use them for props types insrc/CAREUI/display/Card.tsx(link)ReactNodefromreactand use it forprefixprop type insrc/CAREUI/display/RecordMeta.tsx(link)lazyfromreactin various files and use it for loading components asynchronously (link, link, link, link, link, link)loadableimports from various files (link, link, link, link, link, link, link, link, link, link, link)SyntheticEventfromreactand use it for event parameter type inhandleSubmitfunctions insrc/Components/Facility/AddBedForm.tsxandsrc/Components/Facility/AddLocationForm.tsx(link, link, link, link)RefObjectandcreateReffromreactand use them for creating refs for form fields insrc/Components/Facility/AssetCreate.tsx(link, link)