Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative time for audit log details. #6640

Merged
merged 11 commits into from
Dec 6, 2023

Conversation

AshrafMd-1
Copy link
Contributor

@AshrafMd-1 AshrafMd-1 commented Nov 15, 2023

WHAT

🤖 Generated by Copilot at f7dfbc3

Refactored UI code for shift record dates using RecordMeta component in ShiftDetails.tsx. This improved the code quality and user experience.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at f7dfbc3

  • Refactor the created and modified date display to use a custom RecordMeta component (link, link, link)

@AshrafMd-1 AshrafMd-1 requested a review from a team November 15, 2023 13:17
@AshrafMd-1 AshrafMd-1 requested a review from a team as a code owner November 15, 2023 13:17
Copy link

vercel bot commented Nov 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2023 9:18am

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 1973b0e
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/656c47ce328f490008fc75a7
😎 Deploy Preview https://deploy-preview-6640--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The created and last edited by object can also be specified to RecordMeta itself

@nihal467
Copy link
Member

@AshrafMd-1
image

  • dont use two different row, make use of only one row similar to the existing UI

@nihal467
Copy link
Member

@AshrafMd-1 once you complete the UI, we discussed on the EOD call, mark it for testing

@AshrafMd-1
Copy link
Contributor Author

@rithviknishad can u check once

@nihal467
Copy link
Member

nihal467 commented Dec 5, 2023

LGTM

@khavinshankar khavinshankar merged commit 947978c into coronasafe:develop Dec 6, 2023
34 of 36 checks passed
@AshrafMd-1 AshrafMd-1 deleted the Fix-#6638 branch December 6, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use relative time / RecordMeta component for audit log details in shift details
4 participants