Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACV2-1619] Remediate next and markdownlint-cli2 Vulnerabilities #142

Closed
wants to merge 1 commit into from

Conversation

justincorsha
Copy link
Contributor

@justincorsha justincorsha commented May 20, 2024

Before you submit your PR, make sure you check each of the following:

  1. I have read the Contributing Guidelines and signed the Contributor License Agreement.
  2. My code is clean and ready-to-PR, including being free of lint errors and dead code
  3. I have tested my change / code and am confident that it works
  4. I have filled in the template below completely and accurately
Changelog
  • Ran npm audit fix --force (to force breaking changes, which were checked in regression testing) to update next and markdownlint-cli2 packages and remediate vulnerabilities
Testing
  • Ran npm audit and checked that zero vulnerabilities were found
  • Stood up Cast, checked that there were no regressions and that all analyses displayed correctly:
    Screenshot 2024-05-20 at 11 28 50 AM
Unit Tests

@justincorsha
Copy link
Contributor Author

Converting to draft to investigate using dependabot for all current vulnerabilities

@justincorsha justincorsha marked this pull request as draft May 20, 2024 15:43
@justincorsha justincorsha marked this pull request as draft May 20, 2024 15:43
@justincorsha justincorsha marked this pull request as draft May 20, 2024 15:43
@justincorsha
Copy link
Contributor Author

Closing in favor of dependabot PR: #143

@justincorsha justincorsha deleted the acv2-1619-resolve-vulns branch May 22, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant