Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAST-303]Fix SQL geo_ip_data table to accomodate new extra column in GeoLite2-… #148

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

jacobCorsha
Copy link
Contributor

…City-Blocks-IPv4.csv

Before you submit your PR, make sure you check each of the following:

  1. I have read the Contributing Guidelines and signed the Contributor License Agreement.
  2. My code is clean and ready-to-PR, including being free of lint errors and dead code
  3. I have tested my change / code and am confident that it works
  4. I have filled in the template below completely and accurately
Changelog

Updated the init.sql file realign the geo_ip_data table to the schema defined by MAXMIND at https://dev.maxmind.com/geoip/importing-databases/postgresql. This reestablished the ability to utlize Maxmind GeoLite2 Data.

Testing

Briefly describe how you are sure your code works, and be sure to include:

  1. Ran cast without uploading GeoLite2 CSVs to ensure normal functionality remained
  2. Ran cast with ban FEODO Banlist data extension to ensure it was not changed.
  3. Ran cast with curl post call to upload GeoLite2-City-Blocks-IPv4.csv checked if things broke.
  4. Ran cast with curl post call to upload GeoLite2-City-Locations-en.csv checked if things broke.
  5. Ran cast with curl post calls to uplaod both GeoLite2-City-Blocks-IPv4.csv and GeoLite2-City-Locations-en.csv. Examined the outputs to see if it caught and labeled geo_id tagged entities as per expectations.
Screenshot 2024-07-10 at 4 26 40 PM
Unit Tests

N/A

Copy link
Collaborator

@DavidCorsha DavidCorsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you add the ticket number to the PR title?

@jacobCorsha jacobCorsha changed the title Fix SQL geo_ip_data table to accomodate new extra column in GeoLite2-… [CAST-303]Fix SQL geo_ip_data table to accomodate new extra column in GeoLite2-… Jul 11, 2024
@DavidCorsha DavidCorsha merged commit 7421324 into main Jul 11, 2024
4 checks passed
Copy link
Contributor

@justincorsha justincorsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find! Thanks for fixing up the schema 🚀

@jacobCorsha jacobCorsha deleted the geoIP_update branch July 11, 2024 18:07
@jacobCorsha jacobCorsha restored the geoIP_update branch July 12, 2024 13:23
@jacobCorsha jacobCorsha deleted the geoIP_update branch July 19, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants